Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[2/N] Data Sources #264

Merged
merged 10 commits into from
May 8, 2021
Merged

[2/N] Data Sources #264

merged 10 commits into from
May 8, 2021

Conversation

edgarriba
Copy link
Contributor

What does this PR do?

Continuation of #256

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edgarriba edgarriba requested a review from edenlightning as a code owner May 7, 2021 21:59
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #264 (bec3a34) into master (ce63fd7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          68       68           
  Lines        3288     3288           
=======================================
  Hits         2904     2904           
  Misses        384      384           
Flag Coverage Δ
unittests 88.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/classification/transforms.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce63fd7...bec3a34. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris merged commit 8559e9c into master May 8, 2021
@ethanwharris ethanwharris deleted the feature/notebook/data_sources branch May 8, 2021 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants