Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add missing arguments and docs #245

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Apr 24, 2021

What does this PR do?

Adds missing multi-label arguments following #230

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #245 (63839f5) into master (7486c33) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   87.52%   87.51%   -0.01%     
==========================================
  Files          59       59              
  Lines        3053     3051       -2     
==========================================
- Hits         2672     2670       -2     
  Misses        381      381              
Flag Coverage Δ
unittests 87.51% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/classification/data.py 82.47% <ø> (ø)
flash/text/classification/model.py 93.75% <ø> (-0.19%) ⬇️
flash/core/classification.py 92.85% <100.00%> (+0.79%) ⬆️
flash/tabular/classification/model.py 87.50% <100.00%> (+0.54%) ⬆️
flash/vision/classification/model.py 96.00% <100.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7486c33...63839f5. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! nice.

Copy link
Contributor

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanwharris ethanwharris merged commit d296783 into master Apr 26, 2021
@ethanwharris ethanwharris deleted the bugfix/missing_arguments branch April 26, 2021 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants