Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix doc string example in TranslationData #221

Merged

Conversation

mabu-dev
Copy link
Contributor

What does this PR do?

This is a fix for an incorrect example in the doc string of from_files in TranslationData

PR review

  • Yes

@Borda
Copy link
Member

Borda commented Apr 17, 2021

@mabu-dev mind resolve conflits? 🐰

@Borda Borda added the bug / fix Something isn't working label Apr 17, 2021
@mabu-dev
Copy link
Contributor Author

@mabu-dev mind resolve conflits? 🐰

Done! Sorry about that. :)

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #221 (124c0e6) into master (54e569b) will not change coverage.
The diff coverage is n/a.

❗ Current head 124c0e6 differs from pull request most recent head e5b6bdd. Consider uploading reports for the commit e5b6bdd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          62       62           
  Lines        3313     3313           
=======================================
  Hits         2890     2890           
  Misses        423      423           
Flag Coverage Δ
unittests 87.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/seq2seq/translation/data.py 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e569b...e5b6bdd. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@Borda Borda enabled auto-merge (squash) April 28, 2021 13:55
@Borda Borda added Ready to Go documentation Improvements or additions to documentation and removed bug / fix Something isn't working labels Apr 28, 2021
@ethanwharris ethanwharris disabled auto-merge May 4, 2021 07:54
@ethanwharris ethanwharris merged commit ec404e8 into Lightning-Universe:master May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation Ready to Go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants