Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add pre_metric_transform hook #219

Closed
wants to merge 4 commits into from
Closed

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Apr 16, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #219 (f0faf2b) into master (14502b0) will decrease coverage by 3.70%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   86.56%   82.86%   -3.71%     
==========================================
  Files          57       57              
  Lines        2747     2754       +7     
==========================================
- Hits         2378     2282      -96     
- Misses        369      472     +103     
Flag Coverage Δ
unittests 82.86% <90.00%> (-3.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/classification/model.py 62.50% <0.00%> (-31.25%) ⬇️
flash/core/classification.py 100.00% <100.00%> (ø)
flash/core/model.py 96.31% <100.00%> (+0.09%) ⬆️
flash/tabular/classification/model.py 86.95% <100.00%> (ø)
flash/vision/classification/model.py 95.83% <100.00%> (ø)
flash/text/seq2seq/core/data.py 42.62% <0.00%> (-40.99%) ⬇️
flash/text/classification/data.py 40.90% <0.00%> (-40.91%) ⬇️
flash/text/seq2seq/summarization/data.py 57.14% <0.00%> (-28.58%) ⬇️
flash/text/seq2seq/translation/model.py 55.55% <0.00%> (-16.67%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14502b0...f0faf2b. Read the comment docs.

@ethanwharris
Copy link
Collaborator Author

Being dealt with in #216

@Borda Borda deleted the pre_metric_transform branch April 17, 2021 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants