This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[doc] Add DataPipeline + Callbacks + Registry #207
[doc] Add DataPipeline + Callbacks + Registry #207
Changes from 9 commits
32c62ee
ba3fcb8
befd139
1a7e5ae
f115d76
f84df82
ed2d892
2edbbae
4cfc462
a14e716
cc7ad42
f1cecfc
b09ef92
65d9a6b
9e32e77
9541cd3
f1205cb
83362a1
7bd73c3
b49dac5
7d38374
caa3b3e
9ca6f8c
922488c
4f8b52d
5ca0c3e
1c33a4a
846b7d5
c096c6f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not start with notes since it doesn't look good (esp not 2 notes). I would take is out of the note.
3.b ....
A :class:
~flash.data.process.Preprocess
object provides a series of hooks that can be overridden with custom data processing logic.It allows the user much more granular control over their data processing flow.
and then add the note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain in a sentence what are the hooks you need to override in this case and what logic did you add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would skip this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am following Lightning docs there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know its long but any reason not to be explicit and call it visualization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing context.
What are these objects? Why do they exist? when do I need to use them?
I think we can do something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Definitely. I will work on this next week :)