This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
expose scheduler to Task #189
Closed
aniketmaurya
wants to merge
12
commits into
Lightning-Universe:master
from
aniketmaurya:integrate-scheduler
Closed
expose scheduler to Task #189
aniketmaurya
wants to merge
12
commits into
Lightning-Universe:master
from
aniketmaurya:integrate-scheduler
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketmaurya
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
tchaton and
teddykoker
as code owners
March 23, 2021 13:05
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 86.53% 86.48% -0.05%
==========================================
Files 57 57
Lines 2732 2737 +5
==========================================
+ Hits 2364 2367 +3
- Misses 368 370 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tchaton
reviewed
Mar 24, 2021
tchaton
reviewed
Apr 12, 2021
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Hello @aniketmaurya! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-12 19:34:55 UTC |
@ethanwharris @tchaton @aniketmaurya is there any progress here? |
Dear @aniketmaurya, Awesome work with this PR. I took some inspirations from it and finish it in this PR: #232. Closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#175
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃