Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

resolve CI/sudo and minor code adjustments #1698

Merged
merged 1 commit into from
Oct 8, 2023
Merged

resolve CI/sudo and minor code adjustments #1698

merged 1 commit into from
Oct 8, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 8, 2023

What does this PR do?

resolving sudo and a few isinstance

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Sorry, something went wrong.

@Borda Borda requested a review from ethanwharris as a code owner October 8, 2023 11:32
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #1698 (b5e294c) into master (3c55c76) will increase coverage by 0%.
Report is 3 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1698   +/-   ##
======================================
  Coverage      85%     85%           
======================================
  Files         291     291           
  Lines       12859   12859           
======================================
+ Hits        10986   10987    +1     
+ Misses       1873    1872    -1     

@Borda Borda changed the title try tp make it green resolve CI/sudo and minor code adjustments Oct 8, 2023
@Borda Borda merged commit a374dd4 into master Oct 8, 2023
42 checks passed
@Borda Borda deleted the update branch October 8, 2023 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant