Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Pin sahi to fix object detection when installing in a fresh environment #1496

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

See discussion in #1493

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 92.35% // Head: 92.34% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (6ec4918) compared to base (34caca4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   92.35%   92.34%   -0.01%     
==========================================
  Files         292      292              
  Lines       13160    13160              
==========================================
- Hits        12154    12153       -1     
- Misses       1006     1007       +1     
Flag Coverage Δ
pytest 13.02% <ø> (ø)
tpu 13.02% <ø> (ø)
unittests 92.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/question_answering/model.py 93.87% <0.00%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Borda Borda merged commit 002f52d into master Dec 23, 2022
@Borda Borda deleted the bugfix/icevision_plain_install branch December 23, 2022 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants