Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

CI: Use new syntax for setting github output #1477

Merged
merged 4 commits into from
Nov 5, 2022
Merged

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Oct 31, 2022

What does this PR do?

Same as Lightning-AI/pytorch-lightning#15415.

weekend chore 🧹

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta changed the title Update github output CI: Use new syntax for setting github output Oct 31, 2022
@akihironitta akihironitta added the tests / CI Tests and continuous integration label Oct 31, 2022
@krshrimali
Copy link
Contributor

Hi, @akihironitta - Thanks for your PRs to Flash. The CI should be fixed once #1479 is merged. Post that, let's get this one merged as well. Thank you for your patience.

@Borda Borda enabled auto-merge (squash) November 5, 2022 09:14
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 92.88% // Head: 92.36% // Decreases project coverage by -0.52% ⚠️

Coverage data is based on head (b88dbaf) compared to base (eb2113a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
- Coverage   92.88%   92.36%   -0.53%     
==========================================
  Files         292      292              
  Lines       13080    13158      +78     
==========================================
+ Hits        12149    12153       +4     
- Misses        931     1005      +74     
Flag Coverage Δ
pytest 13.03% <ø> (?)
tpu 13.03% <ø> (?)
unittests 92.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/cli.py 83.33% <0.00%> (-16.67%) ⬇️
flash/pointcloud/detection/cli.py 83.33% <0.00%> (-16.67%) ⬇️
flash/pointcloud/segmentation/cli.py 83.33% <0.00%> (-16.67%) ⬇️
flash/text/question_answering/cli.py 83.33% <0.00%> (-16.67%) ⬇️
flash/audio/speech_recognition/cli.py 83.33% <0.00%> (-16.67%) ⬇️
flash/text/seq2seq/summarization/cli.py 83.33% <0.00%> (-16.67%) ⬇️
flash/image/detection/cli.py 84.61% <0.00%> (-15.39%) ⬇️
flash/audio/classification/cli.py 84.61% <0.00%> (-15.39%) ⬇️
flash/video/classification/cli.py 84.61% <0.00%> (-15.39%) ⬇️
flash/tabular/classification/cli.py 84.61% <0.00%> (-15.39%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Borda Borda merged commit dec57a9 into master Nov 5, 2022
@Borda Borda deleted the ci/update-github-output branch November 5, 2022 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants