-
Notifications
You must be signed in to change notification settings - Fork 210
Refactor: use PIL as default image format #1319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part-1 of my review. I'll appreciate it if you can briefly explain why this was required, and what was the problem before (it will be easier to review and land if all looks good). :)
Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Few comments. Let's merge this before updating #1313 so that it can work directly with the PIL image
Hi, @Borda - Would you mind adding tests to this PR? Just a sample test will work, even if it fails, I'll take it from there. Thanks! |
Hi, @Borda - Just a gentle ping, if you can write a test (as I mentioned before - no need to ensure that it passes, just a template test that helps me understand what you are trying to achieve here will help) - that will be great! Please ping me once you are done, also don't worry about the merge conflicts. I'll take care of it, just force push the test. :) |
@krshrimali @ethanwharris may pls get your help on this collision resolution... 🐰 |
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
==========================================
- Coverage 92.29% 86.28% -6.02%
==========================================
Files 287 287
Lines 13056 13047 -9
==========================================
- Hits 12050 11257 -793
- Misses 1006 1790 +784
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What does this PR do?
follow-up to #1313 as the Tensor formating is not very friendly to other general augmentation packages
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃