This repository was archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 210
Support latest version of BaaL (1.5.2) and add necessary utilities #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
commented
Apr 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #1315 +/- ##
==========================================
- Coverage 91.47% 91.47% -0.01%
==========================================
Files 287 287
Lines 12881 12892 +11
==========================================
+ Hits 11783 11793 +10
- Misses 1098 1099 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ethanwharris
reviewed
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there 😃 Couple of suggestions / comments
37bdcba
to
7d53773
Compare
ethanwharris
reviewed
May 6, 2022
ethanwharris
reviewed
May 6, 2022
ethanwharris
reviewed
May 6, 2022
ethanwharris
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
ethanwharris
added a commit
that referenced
this pull request
May 11, 2022
…1315) Co-authored-by: Ethan Harris <[email protected]>
ethanwharris
added a commit
that referenced
this pull request
May 11, 2022
…1315) Co-authored-by: Ethan Harris <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1297.
This PR attempts to add support for latest version of BaaL. PR: baal-org/baal#194 changed the way dropout layers were changed. Please also note that vissl dependencies were in conflict with BaaL, because of the way vissl decided to be way too strict with its requirements. Following error is raised when attempting to install BaaL with vissl:
The solution I'm proposing is to have a separate requirements file for BaaL. Locally, it will still raise some errors but BaaL will still be installed with warnings for conflicts (NumPy and scikit-learn).
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
cc: @ethanwharris