This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Remove model.predict #1030
Merged
Remove model.predict #1030
+420
−407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
approved these changes
Dec 6, 2021
| @@ -472,63 +470,6 @@ def test_step(self, batch: Any, batch_idx: int) -> None: | |||
| prog_bar=True, | |||
| ) | |||
|
|
|||
| @predict_context | |||
| def predict( | |||
| ) -> "FaceDetectionData": | ||
| return cls( | ||
| predict_dataset=ImageClassificationFilesInput(RunningStage.PREDICTING, predict_files), | ||
| input_transform=cls.input_transform_cls(predict_transform=predict_transform), |
There was a problem hiding this comment.
We will have to move those to the new API in a future PR. Just a reminder.
flash_examples/integrations/labelstudio/video_classification.py
Outdated
Show resolved
Hide resolved
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ethanwharris
requested review from
ananyahjha93,
Borda,
carmocca,
edenlightning,
justusschock and
kaushikb11
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
==========================================
- Coverage 87.12% 87.09% -0.03%
==========================================
Files 254 254
Lines 13790 13778 -12
==========================================
- Hits 12014 12000 -14
- Misses 1776 1778 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1004
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃