Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.1rc2 - a couple small bugfixes #205

Merged

Conversation

nateraw
Copy link
Contributor

@nateraw nateraw commented Sep 11, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes bug that's causing our builds to fail on missing progress_bar_metrics attribute of trainer.

Seems to have been caused by this PR.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@nateraw nateraw added fix fixing issues... Priority High priority task labels Sep 11, 2020
@mergify mergify bot requested a review from Borda September 11, 2020 05:02
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          74       74           
  Lines        3298     3298           
=======================================
  Hits         2943     2943           
  Misses        355      355           
Flag Coverage Δ
#unittests 89.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._bolts/models/self_supervised/moco/moco2_module.py 80.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850db3d...74af866. Read the comment docs.

@nateraw nateraw changed the title use progress_bar_dict not progress_bar_metrics 0.9.1rc2 - a couple small bugfixes Sep 11, 2020
@nateraw
Copy link
Contributor Author

nateraw commented Sep 11, 2020

@williamFalcon pls merge first thing in the morning.

@williamFalcon williamFalcon merged commit 8157faf into Lightning-Universe:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues... Priority High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants