This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
add support for precision="16-mixed" #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==================================
Coverage 35% 35%
==================================
Files 4 4
Lines 274 274
==================================
Hits 97 97
Misses 177 177 |
awaelchli
approved these changes
Feb 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Lightning-AI/pytorch-lightning#16783,
precision=16will change toprecision='16-mixed'. This PR enables support for it.A follow-up PR will disable support for
precision=16in the plugin and strategy once Lightning-AI/pytorch-lightning#16783 has landed.Since right now nothing really changes, the follow-up PR will include the Changelog.