Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower min packaging version #91

Merged
merged 2 commits into from
Jan 24, 2023
Merged

lower min packaging version #91

merged 2 commits into from
Jan 24, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 24, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

as changed in #76 and discovered in Lightning-AI/pytorch-lightning#16476 (comment)
so we can re-release with post suffix

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda enabled auto-merge (squash) January 24, 2023 18:35
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for debugging this!

@Borda Borda merged commit 5d310d0 into main Jan 24, 2023
@Borda Borda deleted the ci/packaging branch January 24, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants