Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove duplicate try to publish #114

Merged
merged 1 commit into from
Feb 23, 2023
Merged

ci: remove duplicate try to publish #114

merged 1 commit into from
Feb 23, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 23, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

the trigger is tag and release so we upload only on release but the publish was passing on both event...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from akihironitta as a code owner February 23, 2023 11:38
@Borda Borda changed the title ci: remove duplicate try to upload ci: remove duplicate try to publish Feb 23, 2023
@Borda Borda merged commit 9dfe22d into main Feb 23, 2023
@Borda Borda deleted the ci/pypi-event branch February 23, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants