Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add py.typed to MANIFEST.in #101

Merged

Conversation

alexandervaneck
Copy link
Contributor

@alexandervaneck alexandervaneck commented Feb 7, 2023

The py.typed file was added but did not become part of the distribution.

Fixes #15889

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #15889 (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

The `py.typed` file was added but did not become part of the distribution.

Fixes #15889
MANIFEST.in Outdated Show resolved Hide resolved
Co-authored-by: Jirka Borovec <[email protected]>
@Borda Borda enabled auto-merge (squash) February 7, 2023 14:17
@Borda Borda added the bug Something isn't working label Feb 7, 2023
@Borda Borda merged commit 1adb06c into Lightning-AI:main Feb 7, 2023
@alexandervaneck
Copy link
Contributor Author

Thanks for the fast resolve @Borda @akihironitta 🙇

@alexandervaneck alexandervaneck deleted the fix/15889-missed-py.typed-in-manifest branch February 7, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lightning_utilities] Missed py.typed file causes type hinting errors
4 participants