minor code cleaning #982
Merged
minor code cleaning #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
awaelchli,
ethanwharris,
SkafteNicki,
justusschock,
tchaton and
SeanNaren
as code owners
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 177 177
Lines 7518 7518
=====================================
Hits 7142 7142
Misses 376 376 |
for more information, see https://pre-commit.ci
stancld
approved these changes
Apr 24, 2022
justusschock
approved these changes
Apr 25, 2022
Co-authored-by: Justus Schock <[email protected]>
SkafteNicki
approved these changes
Apr 25, 2022
for more information, see https://pre-commit.ci
Borda
added a commit
that referenced
this pull request
Apr 26, 2022
* minor code cleaning * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Justus Schock <[email protected]> (cherry picked from commit e236821)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃