-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added adaptive_k
argument to IR Precision metric
#910
Conversation
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 173 173
Lines 7339 7344 +5
=====================================
- Hits 6971 6963 -8
- Misses 368 381 +13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add changelog entry
Co-authored-by: Jirka Borovec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that the parameter should also be added to the modular metrics
@lucadiliello pls check #910 (review) ^^ |
LGTM |
@lucadiliello not sure if I understand, so does the parameter shall also be added to the modular metrics? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added it both to the functional and the modular version of |
What does this PR do?
Fixes #886
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃