-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new image metric - d_lambda
#873
Adds new image metric - d_lambda
#873
Conversation
for more information, see https://pre-commit.ci
…trics into feature/799_d_lambda_metric
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #873 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 173 175 +2
Lines 7401 7468 +67
=====================================
+ Hits 7029 7094 +65
- Misses 372 374 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, otherwise LGTM already from #855
Co-authored-by: Daniel Stancl <[email protected]>
Co-authored-by: Daniel Stancl <[email protected]>
Co-authored-by: Daniel Stancl <[email protected]>
Co-authored-by: Daniel Stancl <[email protected]>
Co-authored-by: Daniel Stancl <[email protected]>
Co-authored-by: Daniel Stancl <[email protected]>
…trics into feature/799_d_lambda_metric
…trics into feature/799_d_lambda_metric
for more information, see https://pre-commit.ci
@SkafteNicki @justusschock pls ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few commets, else LGTM
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
Hi @SkafteNicki, I have updated the branch, please take a look again whenever you have the time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final comments (just for consistency in naming)
Please see the previous PR here which was accidentally closed (the repo got deleted...).
What does this PR do?
Adds New Image Metric - D_Lambda (Spectral Distortion Index)
Fixes a part of #799
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃