Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing time #820

Merged
merged 22 commits into from
Feb 4, 2022
Merged

Improve testing time #820

merged 22 commits into from
Feb 4, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 1, 2022 •
edited by Borda
Loading

What does this PR do?

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the test / CI testing or CI label Feb 1, 2022
@SkafteNicki SkafteNicki added this to the v0.8 milestone Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #820 (f8ca3b5) into master (59998ce) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #820   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         166    166           
  Lines        6832   6832           
=====================================
  Hits         6486   6486           
  Misses        346    346

@SkafteNicki SkafteNicki marked this pull request as ready for review February 3, 2022 11:34
@SkafteNicki
Copy link
Member Author

Not ready for review, just need all tests to run to see effect of changes.

SkafteNicki
SkafteNicki commented Feb 3, 2022
View reviewed changes
tests/helpers/testers.py Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki mentioned this pull request Feb 3, 2022
Merged
4 tasks
Borda
Borda reviewed Feb 3, 2022
View reviewed changes
tests/helpers/testers.py Outdated Show resolved Hide resolved
SkafteNicki
SkafteNicki commented Feb 4, 2022
View reviewed changes
requirements/image.txt Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki changed the title [WIP] Improve testing time Improve testing time Feb 4, 2022
@Borda Borda self-requested a review February 4, 2022 11:15
@Borda Borda added the enhancement New feature or request label Feb 4, 2022
Borda
Borda reviewed Feb 4, 2022
View reviewed changes
.github/workflows/ci_test-full.yml Outdated Show resolved Hide resolved
requirements/image.txt Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) February 4, 2022 22:30
@Borda Borda merged commit ac6539b into master Feb 4, 2022
@Borda Borda deleted the test_speed branch February 4, 2022 23:12
@mergify mergify bot added the ready label Feb 4, 2022
@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees
No one assigned
Labels
enhancement New feature or request ready test / CI testing or CI
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@SkafteNicki @awaelchli @Borda @tchaton