-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code from image domain #796
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add chlog with removal
@Borda integration test are failing due to |
so shall we keep this deprecation? |
Personally, wouldn't keep it. If we keep it, we should keep them all, I think and extend the deprecation phase. Which Lightning Version is it? |
If we keep it, we would only support lightning 1.5 as that release removed metrics completely.
|
you mean if we remove deprecated metrics, right? |
Yes :] |
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 166 165 -1
Lines 6827 6776 -51
=====================================
- Hits 6452 6427 -25
+ Misses 375 349 -26 |
What does this PR do?
Fixes part of #771
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃