Remove lightning legacy code and references #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
documentation
SkafteNicki
requested review from
Borda,
edenlightning,
justusschock and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 166 166
Lines 6832 6827 -5
=====================================
+ Hits 6457 6481 +24
+ Misses 375 346 -29 |
Borda
approved these changes
Jan 20, 2022
auto-merge was automatically disabled
January 27, 2022 20:36
Pull Request is not mergeable
…hLightning/metrics into deprecated_lightning_code
Borda
approved these changes
Jan 31, 2022
Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
justusschock
reviewed
Feb 1, 2022
Co-authored-by: Justus Schock <[email protected]>
justusschock
approved these changes
Feb 1, 2022
carmocca
reviewed
Feb 1, 2022
awaelchli
approved these changes
Feb 1, 2022
carmocca
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #739 we (silently) decided to only support v1.3 of lightning moving forward (increased from 1.0).
This PR increases the requirement once again to v1.5 because we need to remove some deprecated metrics that was still present in `pytorch_lightning.metrics (PL<1.5).
Additionally removed some legacy code and reference to lightning.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃