Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pyDeprecate #745

Merged
merged 4 commits into from
Jan 12, 2022
Merged

refactor: pyDeprecate #745

merged 4 commits into from
Jan 12, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 11, 2022 •
edited
Loading

What does this PR do?

replace all warnings by pyDeprecate wrapper
related to #729 and #716

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jan 11, 2022
@Borda Borda added this to the v0.7 milestone Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #745 (ae5dd85) into master (83345d7) will decrease coverage by 0%.
The diff coverage is 66%.

@@          Coverage Diff          @@
##           master   #745   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         170    170           
  Lines        6760   6759    -1     
=====================================
- Hits         6422   6398   -24     
- Misses        338    361   +23

@Borda Borda marked this pull request as draft January 12, 2022 16:25
@Borda
Copy link
Member Author

Borda commented Jan 12, 2022

@SkafteNicki regarding your approval #723 (comment) mind review this one 🐰

@Borda Borda mentioned this pull request Jan 12, 2022
Closed
@Borda Borda marked this pull request as ready for review January 12, 2022 20:31
@Borda Borda enabled auto-merge (squash) January 12, 2022 20:31
ethanwharris
ethanwharris approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready label Jan 12, 2022
@Borda Borda merged commit d3cab93 into master Jan 12, 2022
@Borda Borda deleted the refactor/pyDeprecate branch January 12, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki is a code owner

@tchaton tchaton Awaiting requested review from tchaton

@quancs quancs Awaiting requested review from quancs

@awaelchli awaelchli Awaiting requested review from awaelchli

@lucadiliello lucadiliello Awaiting requested review from lucadiliello

@maximsch2 maximsch2 Awaiting requested review from maximsch2

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@stancld stancld Awaiting requested review from stancld stancld is a code owner

Assignees
No one assigned
Labels
ready refactoring refactoring and code health
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @SeanNaren @ethanwharris