-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename peak_signal_noise_ratio
#732
Conversation
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 170 170
Lines 6742 6751 +9
=====================================
+ Hits 6402 6411 +9
Misses 340 340 |
Hi @Fariborzzz, it seems this PR is changing a lot more file than intended. Could you fix that? |
the case seems to be that you have by default some different file permissions which yielded in all project changes, for next time is better to set your git to ignore file permissions before committing changes
|
This reverts commit 6e95772.
@Fariborzzz shall be fixed now 🐰 |
Thank you @SkafteNicki and @Borda. Sure, I'll set up git ignore for my next commits 😃! |
Hi @Fariborzzz, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecation warnings & back compatibility
@Fariborzzz could you pls resolve the conflict or shall I do it for you? 🐰 |
for more information, see https://pre-commit.ci
What does this PR do?
Change
'PSNR' to 'PeakSignalNoiseRatio'
psnr
topeak_signal_noise_ratio
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yep 😄
Make sure you had fun coding 🙃