Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MultiScaleStructuralSimilarityIndexMeasure #679

Merged
merged 53 commits into from
Jan 10, 2022
Merged

Add MultiScaleStructuralSimilarityIndexMeasure #679

merged 53 commits into from
Jan 10, 2022

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Dec 11, 2021 •
edited
Loading

What does this PR do?

This PR adds Multi-Scale Structural Similarity Index Measure.

Fixes #522

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 11, 2021 •
edited
Loading

Codecov Report

Merging #679 (b5aeb83) into master (c20860a) will decrease coverage by 0%.
The diff coverage is 86%.

@@          Coverage Diff          @@
##           master   #679   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         166    168    +2     
  Lines        6494   6590   +96     
=====================================
+ Hits         6185   6267   +82     
- Misses        309    323   +14

@stancld stancld changed the title [WIP] Add MS-SSIM [WIP] Add MS-SSIM Dec 11, 2021
@Borda Borda added this to the v0.7 milestone Dec 12, 2021
SkafteNicki
SkafteNicki reviewed Dec 15, 2021
View reviewed changes
@stancld
Copy link
Contributor Author

stancld commented Dec 15, 2021

Regarding the flake8 issue. Shouldn't we ignore W503 # Ignore "Line break occurred before a binary operator" as it is the case in PL? I think black is incompatible with W503 in general. @Borda @SkafteNicki

@Borda
Copy link
Member

Borda commented Dec 17, 2021

Regarding the flake8 issue. Shouldn't we ignore W503 # Ignore "Line break occurred before a binary operator" as it is the case in PL? I think black is incompatible with W503 in general

you are right, but the beauty of coding is that there is always at least one more way how to write/code the same... :]

@Borda
Copy link
Member

Borda commented Dec 17, 2021

@stancld the formating shall be fixed ow so what else needs to be done before review?

@stancld
Copy link
Contributor Author

stancld commented Dec 17, 2021

@Borda I have to write proper testing - will do it tomorrow. Then it should be hopefully ready to merge

@stancld stancld marked this pull request as ready for review December 18, 2021 21:30
mergify bot and others added 3 commits January 8, 2022 19:35
@mergify
Merge branch 'master' into ms-ssim
4f13138
@Borda @pre-commit-ci
Refactor: SNR & SI_SNR (Lightning-AI#712)
b7518dd 
* signal_noise_ratio
* scale_invariant_signal_noise_ratio
* SignalNoiseRatio

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@mergify
Merge branch 'master' into ms-ssim
0a7447d
@mergify mergify bot added the ready label Jan 8, 2022
@mergify mergify bot added the has conflicts label Jan 9, 2022
@mergify mergify bot added the ready label Jan 9, 2022
@SkafteNicki SkafteNicki merged commit 9288222 into Lightning-AI:master Jan 10, 2022
Borda added a commit that referenced this pull request Jan 10, 2022
@stancld @Borda @SkafteNicki
Add MultiScaleStructuralSimilarityIndexMeasure (#679)
94dec52 
* Apply suggestions from code review
* Change naming multiscale_ssim -> multiscale_structual_similarity_index_measure

Co-authored-by: Jirka <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Borda added a commit that referenced this pull request Jan 10, 2022
@stancld @Borda @SkafteNicki
Add MultiScaleStructuralSimilarityIndexMeasure (#679)
fb192e8 
* Apply suggestions from code review
* Change naming multiscale_ssim -> multiscale_structual_similarity_index_measure

Co-authored-by: Jirka <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Borda added a commit that referenced this pull request Jan 10, 2022
@stancld @Borda @SkafteNicki
Add MultiScaleStructuralSimilarityIndexMeasure (#679)
793d501 
* Apply suggestions from code review
* Change naming multiscale_ssim -> multiscale_structual_similarity_index_measure

Co-authored-by: Jirka <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@edenlightning edenlightning Awaiting requested review from edenlightning

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees

@stancld stancld

Labels
New metric ready topic: Image
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Add MS-SSIM
5 participants
@stancld @Borda @awaelchli @SkafteNicki @maximsch2