Fix ComputationalMetric.forward() to not only consider the last batch #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callidior
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
SkafteNicki
reviewed
Nov 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 161 161
Lines 5781 5794 +13
=====================================
+ Hits 5501 5515 +14
+ Misses 280 279 -1 |
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
|
@SkafteNicki Thanks for your suggestions! I committed them as proposed. |
|
Hi @Callidior, |
SkafteNicki
approved these changes
Nov 30, 2021
Borda
reviewed
Nov 30, 2021
Borda
reviewed
Nov 30, 2021
Borda
approved these changes
Nov 30, 2021
Borda
pushed a commit
that referenced
this pull request
Dec 5, 2021
…#645) * Apply suggestions from code review Co-authored-by: Björn Barz <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit b4ec3c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #644
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.