Untokenized Bleu score to stay consistent with all the other text metrics #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrleu
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 163 163
Lines 5994 5998 +4
=====================================
+ Hits 5704 5710 +6
+ Misses 290 288 -2 |
mrleu
force-pushed
the
feature/600_bleu_consistency
branch
from
ac138da to
07b25b0
Compare
|
@stancld please take a look :] |
SkafteNicki
reviewed
Nov 25, 2021
stancld
reviewed
Nov 25, 2021
stancld
reviewed
Nov 25, 2021
stancld
reviewed
Nov 25, 2021
Co-authored-by: Daniel Stancl <[email protected]>
mrleu
commented
Nov 25, 2021
mrleu
commented
Nov 25, 2021
mrleu
force-pushed
the
feature/600_bleu_consistency
branch
from
6227f1c to
11819a1
Compare
mrleu
force-pushed
the
feature/600_bleu_consistency
branch
from
c78c00e to
2f6f955
Compare
|
@SkafteNicki ^^ 🐰 |
|
Ready for review 🙇🏻 |
LGTM! Let's wait for the tests :] |
|
Looks like it failed at https://github.com/PyTorchLightning/metrics/runs/4413710583?check_suite_focus=true#step:13:551, but that looks orthogonal towards this PR? |
yes seems we have some failures on master too... @SkafteNicki mind having a look? |
stancld
approved these changes
Dec 4, 2021
SkafteNicki
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #600
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yep! My first time contributing to pytorch lightning. Very fun :) Please let me know if there's anything that needs to be updated!
Make sure you had fun coding 🙃