Fix MAP metric for empty cases #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
tkupek
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 160 160
Lines 5597 5605 +8
=====================================
+ Hits 5326 5334 +8
Misses 271 271 |
Borda
approved these changes
Nov 18, 2021
|
@tkupek How is it going here? |
SkafteNicki
approved these changes
Nov 24, 2021
justusschock
approved these changes
Nov 24, 2021
Fix MAX DDP multi GPU issue
auto-merge was automatically disabled
November 24, 2021 17:15
Head branch was pushed to by a user without write access
|
I just pushed another commit that fixes the issue mentioned in #626 |
auto-merge was automatically disabled
November 24, 2021 17:22
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
November 24, 2021 18:02
Head branch was pushed to by a user without write access
Borda
pushed a commit
that referenced
this pull request
Dec 5, 2021
* add detection map code example * update setup * simplify named tuple * Update tm_examples/detection_map.py * Update tm_examples/detection_map.py * Update tm_examples/detection_map.py * Update tm_examples/detection_map.py * Update tm_examples/detection_map.py * Update tm_examples/detection_map.py * add some more comments * add some more comments * add example hint in metric docstring * fix evaluation for empty metric * Update torchmetrics/detection/map.py * fix deepsource stuff * update changelog * fix ddp issue in multi GPU setup for empty boxes * update doc * simplify empty tensors fix * fix mypy * fix failing unittests Co-authored-by: Jirka <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 3aef7be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #601 (empty tensors in metric)
Fixes #626 (DDP stuck in multi GPU mode)
Fixes an issue if the metric is evaluated with empty lists
Tests where added for both cases
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃