-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix consistency in the output of scalar tensors #622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…Lightning/metrics into squeeze_1_element_tensor
SkafteNicki
commented
Nov 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 155 155
Lines 5508 5513 +5
=====================================
+ Hits 5236 5244 +8
+ Misses 272 269 -3 |
Borda
approved these changes
Nov 15, 2021
carmocca
reviewed
Nov 15, 2021
awaelchli
approved these changes
Nov 22, 2021
SkafteNicki
commented
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #611
Trying to fix consistency in the output of metrics. If a metric returns a scalar tensor, then sometimes it is
tensor([...])
and other times it is:
tensor(...)
This PR fixes this by doing a squeeze after
compute
if the output hasnumel=1
.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃