Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize req. extras #590

Merged
merged 1 commit into from
Oct 28, 2021
Merged

generalize req. extras #590

merged 1 commit into from
Oct 28, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 28, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #590 (aaf2f93) into master (6f02550) will decrease coverage by 23%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #590     +/-   ##
=======================================
- Coverage      95%    73%    -23%     
=======================================
  Files         150    150             
  Lines        5307   5306      -1     
=======================================
- Hits         5050   3852   -1198     
- Misses        257   1454   +1197     

@Borda Borda merged commit 61e9c9c into master Oct 28, 2021
@Borda Borda deleted the req/extras branch October 28, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant