Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SacreBLEUScore #546

Merged
merged 20 commits into from
Sep 30, 2021
Merged

Add SacreBLEUScore #546

merged 20 commits into from
Sep 30, 2021

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Sep 24, 2021 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #487

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

stancld and others added 6 commits September 24, 2021 19:05
@codecov
Copy link

codecov bot commented Sep 25, 2021 •
edited
Loading

Codecov Report

Merging #546 (34a98ff) into master (85292e0) will decrease coverage by 0%.
The diff coverage is 87%.

@@          Coverage Diff           @@
##           master   #546    +/-   ##
======================================
- Coverage      95%    95%    -0%     
======================================
  Files         130    132     +2     
  Lines        4632   4748   +116     
======================================
+ Hits         4414   4513    +99     
- Misses        218    235    +17

@stancld stancld changed the title [WIP] Add SacreBLEUScore Add SacreBLEUScore Sep 27, 2021
@stancld stancld marked this pull request as ready for review September 27, 2021 11:54
@mergify mergify bot removed the has conflicts label Sep 27, 2021
SkafteNicki
SkafteNicki reviewed Sep 27, 2021
View reviewed changes
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mix of comments but PR is already looking good :]

torchmetrics/__init__.py Show resolved Hide resolved
torchmetrics/text/sacrebleu.py Outdated Show resolved Hide resolved
torchmetrics/text/sacrebleu.py Outdated Show resolved Hide resolved
torchmetrics/text/sacrebleu.py Outdated Show resolved Hide resolved
torchmetrics/text/sacrebleu.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/sacrebleu.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from SkafteNicki September 27, 2021 16:48
@mergify mergify bot added ready and removed ready labels Sep 30, 2021
@mergify mergify bot added the ready label Sep 30, 2021
@stancld stancld requested a review from Borda September 30, 2021 13:51
@SkafteNicki SkafteNicki merged commit c27c9d9 into Lightning-AI:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@Borda Borda Borda approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

Assignees

@SkafteNicki SkafteNicki

Labels
New metric ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support sacrebleu implementation under the BLEUScore metric
3 participants
@stancld @SkafteNicki @Borda