-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change import pattern in TM #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SkafteNicki !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls provide justification of the speed-up
this is a breaking change without any back compatibility!
@SkafteNicki lets follow with #459 (comment) |
@Borda alright lets do it, but we should probably state this somewhere in the documentation? |
for more information, see https://pre-commit.ci
@SkafteNicki that is an interesting failer, that shall happen with the original PR not here... |
Before submitting
What does this PR do?
Fixes #459
Changes the import pattern for metrics requiring third-party packages from
to
the recommended import path will be stated in the example belonging to each metric.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃