-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Blue Score the respective folders #360
Merged
Borda
merged 24 commits into
Lightning-AI:master
from
karthikrangasai:feature/352_add_blue_score
Jul 19, 2021
Merged
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
77645b9
Added Blue Score the respective folders
karthikrangasai 1b9bcf1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] be4ccbd
File naming correction and moved existing tests
karthikrangasai 70cf0bb
Fixes from pre-commit
karthikrangasai 672ea95
Updated function definitions to be in sync with nltk style
karthikrangasai b60e474
Added Blue Score the respective folders
karthikrangasai c03e97c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dad9026
File naming correction and moved existing tests
karthikrangasai ee6166a
Fixes from pre-commit
karthikrangasai 60afb0b
Updated function definitions to be in sync with nltk style
karthikrangasai c15958d
Merge branch 'PyTorchLightning:master' into feature/352_add_blue_score
karthikrangasai 7d4389c
Merge branch 'feature/352_add_blue_score' of https://github.com/karth…
karthikrangasai 39ef530
Updated docs references in the rst files to reflect in the HTML.
karthikrangasai a38a409
Made naming changes for consistency, updated references in docs, adde…
karthikrangasai 5b4f938
Added functional/nlp.py back with Deprecation Warning for current sup…
karthikrangasai 853ffd4
Fixed import error
karthikrangasai 819376f
Updated docstring for deprecation and added tests for metric computat…
karthikrangasai 6d5e599
Merge branch 'master' into feature/352_add_blue_score
SkafteNicki 9273fb8
deprecate
Borda 89e61c2
chlog
Borda b5e5e41
types
Borda 8c15a6b
Fixing doctests, updating test variables types
karthikrangasai 7c466bb
Merge branch 'master' into feature/352_add_blue_score
SkafteNicki 6284f6a
type
Borda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Copyright The PyTorch Lightning team. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from torchmetrics.functional.text.bleu import bleu_score # noqa: F401 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we call it NLP or Text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. NLP also includes speech processing. So, if we are to add those metrics as well then we can call it NLP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, speech processing you mean conversion from audio > text and back, right?
bu then you still shall measure the quality against each independently as your prediction and target are always other audio or text, right? so we can split NLP as text and audio... 🐰
cc: @SkafteNicki @maximsch2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer text, as the data modality that bleu works on is text, similar to how we have grouped other metrics based on data modality.
Also, this does not matter for the end users, as all modular metrics can just be imported with
from torchmetrics import *
and functional `from torchmetrics.functional import *