Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove additional condition #311

Merged
merged 1 commit into from
Jun 24, 2021
Merged

[Refactor] Remove additional condition #311

merged 1 commit into from
Jun 24, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 23, 2021

Before submitting

Remove addition from my previous PR: #302

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton marked this pull request as ready for review June 23, 2021 17:49
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #311 (57d4718) into master (c8f81b1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   96.46%   96.52%   +0.05%     
==========================================
  Files         106      106              
  Lines        3450     3450              
==========================================
+ Hits         3328     3330       +2     
+ Misses        122      120       -2     
Flag Coverage Δ
Linux 75.84% <0.00%> (ø)
Windows 75.84% <0.00%> (ø)
cpu 96.46% <100.00%> (ø)
gpu 96.42% <100.00%> (?)
macOS 96.46% <100.00%> (ø)
pytest 96.52% <100.00%> (+0.05%) ⬆️
python3.6 95.55% <100.00%> (ø)
python3.8 96.46% <100.00%> (ø)
python3.9 96.37% <100.00%> (ø)
torch1.3.1 95.55% <100.00%> (ø)
torch1.4.0 95.65% <100.00%> (ø)
torch1.9.0 96.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/metric.py 95.51% <100.00%> (ø)
torchmetrics/functional/regression/spearman.py 97.77% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f81b1...57d4718. Read the comment docs.

@Borda Borda added enhancement New feature or request refactoring refactoring and code health labels Jun 23, 2021
@Borda Borda enabled auto-merge (squash) June 24, 2021 08:02
@Borda Borda merged commit 93bd76b into master Jun 24, 2021
@Borda Borda deleted the patching branch June 24, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants