Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable specifying weights path for fid #2867

Merged
merged 9 commits into from
Dec 21, 2024
Merged

Conversation

yuvalkirstain
Copy link
Contributor

@yuvalkirstain yuvalkirstain commented Dec 15, 2024

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

In some places compute nodes do have access to internet, so it is important to enable loading metrics without internet access. This PR enables specifying the checkpoint path for FID.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2867.org.readthedocs.build/en/2867/

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I git it but still pls share motivation for this PR

src/torchmetrics/image/fid.py Show resolved Hide resolved
@yuvalkirstain
Copy link
Contributor Author

I did (perhaps not in the right place) - "In some places compute nodes do have access to internet, so it is important to enable loading metrics without internet access. This PR enables specifying the checkpoint path for FID."

@mergify mergify bot added the ready label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38%. Comparing base (3ff199c) to head (97db50a).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3ff199c) and HEAD (97db50a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3ff199c) HEAD (97db50a)
gpu 1 0
unittest 1 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2867     +/-   ##
========================================
- Coverage      69%     38%    -32%     
========================================
  Files         346     332     -14     
  Lines       19133   18957    -176     
========================================
- Hits        13229    7109   -6120     
- Misses       5904   11848   +5944     

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Borda Borda merged commit a7284e2 into Lightning-AI:master Dec 21, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants