-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix so multilabel confusion matrix can plot for 2 or more labels #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podgorki
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
December 3, 2024 05:55
for more information, see https://pre-commit.ci
Borda
reviewed
Dec 3, 2024
Borda
reviewed
Dec 3, 2024
Co-authored-by: Jirka Borovec <[email protected]>
SkafteNicki
approved these changes
Dec 3, 2024
Borda
approved these changes
Dec 11, 2024
auto-merge was automatically disabled
December 11, 2024 07:38
Head branch was pushed to by a user without write access
justusschock
approved these changes
Dec 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2858 +/- ##
=======================================
- Coverage 69% 69% -0%
=======================================
Files 346 332 -14
Lines 19133 18957 -176
=======================================
- Hits 13229 13054 -175
+ Misses 5904 5903 -1 |
Borda
reviewed
Dec 17, 2024
lantiga
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2857
Multilabel plotting failed for two labels and succeeded for greater than two. No test existed for this added one but it also requires matplotlib so that was added to the test requirements
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2858.org.readthedocs.build/en/2858/