Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix so multilabel confusion matrix can plot for 2 or more labels #2858

Merged
merged 19 commits into from
Dec 21, 2024

Conversation

podgorki
Copy link
Contributor

@podgorki podgorki commented Dec 3, 2024

What does this PR do?

Fixes #2857
Multilabel plotting failed for two labels and succeeded for greater than two. No test existed for this added one but it also requires matplotlib so that was added to the test requirements

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • [] Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2858.org.readthedocs.build/en/2858/

requirements/_tests.txt Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Dec 3, 2024
@SkafteNicki SkafteNicki added this to the v1.5.x milestone Dec 3, 2024
@podgorki podgorki requested a review from Borda December 11, 2024 06:04
@Borda Borda enabled auto-merge (squash) December 11, 2024 06:59
auto-merge was automatically disabled December 11, 2024 07:38

Head branch was pushed to by a user without write access

@mergify mergify bot removed the has conflicts label Dec 11, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (a7284e2) to head (c7b5c76).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2858    +/-   ##
=======================================
- Coverage      69%     69%    -0%     
=======================================
  Files         346     332    -14     
  Lines       19133   18957   -176     
=======================================
- Hits        13229   13054   -175     
+ Misses       5904    5903     -1     

@mergify mergify bot added the ready label Dec 16, 2024
@Borda Borda enabled auto-merge (squash) December 17, 2024 11:35
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@mergify mergify bot added has conflicts and removed ready labels Dec 21, 2024
@mergify mergify bot removed the has conflicts label Dec 21, 2024
@mergify mergify bot added the ready label Dec 21, 2024
@Borda Borda merged commit 8827e64 into Lightning-AI:master Dec 21, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
5 participants