-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MetricCollection
compatibility with torch.jit.script
#2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
justusschock,
Borda and
stancld
as code owners
October 31, 2024 09:32
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2813 +/- ##
======================================
Coverage 69% 69%
======================================
Files 344 344
Lines 18823 18824 +1
======================================
+ Hits 12970 12971 +1
Misses 5853 5853 |
Borda
approved these changes
Oct 31, 2024
Borda
pushed a commit
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit abdd2c4)
Borda
pushed a commit
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit abdd2c4)
Borda
pushed a commit
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit abdd2c4)
Borda
pushed a commit
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit abdd2c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2812
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2813.org.readthedocs.build/en/2813/