Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix assert in pit.py #2811

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix assert in pit.py #2811

merged 1 commit into from
Oct 30, 2024

Conversation

StalkerShurik
Copy link
Contributor

@StalkerShurik StalkerShurik commented Oct 30, 2024

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2811.org.readthedocs.build/en/2811/

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35%. Comparing base (0a19c47) to head (cd5688f).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0a19c47) and HEAD (cd5688f). Click for more details.

HEAD has 60 uploads less than BASE
Flag BASE (0a19c47) HEAD (cd5688f)
torch2.0.1+cpu 6 3
python3.10 18 9
Windows 4 2
cpu 28 14
Linux 18 9
python3.8 2 1
torch2.5.0+cpu 2 1
python3.12 6 3
macOS 6 3
torch2.5.0 2 1
torch2.0.1 4 2
torch2.2.2+cpu 2 1
torch2.3.1+cpu 2 1
torch2.1.2+cpu 2 1
python3.11 2 1
torch2.4.1+cu121 4 2
torch2.5.0+cu124 4 2
gpu 2 0
unittest 2 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2811     +/-   ##
========================================
- Coverage      69%     35%    -34%     
========================================
  Files         340     326     -14     
  Lines       18448   18277    -171     
========================================
- Hits        12679    6311   -6368     
- Misses       5769   11966   +6197     

@SkafteNicki SkafteNicki added this to the v1.5.x milestone Oct 30, 2024
@mergify mergify bot added the ready label Oct 30, 2024
@Borda Borda merged commit 429556b into Lightning-AI:master Oct 30, 2024
56 checks passed
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 429556b)
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 429556b)
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 429556b)
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 429556b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants