Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding numpy 2+ support #2804

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

adamjstewart
Copy link
Contributor

@adamjstewart adamjstewart commented Oct 24, 2024

What does this PR do?

The ability to install torchmetrics with numpy 2 was removed in #2692 due to a dependency that does not yet support numpy 2. However, this dependency (PESQ) is optional, so there is no reason to prevent the base installation from using numpy 2.

@Borda

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2804.org.readthedocs.build/en/2804/

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68%. Comparing base (d87aff7) to head (46a4354).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2804    +/-   ##
=======================================
- Coverage      69%     68%    -0%     
=======================================
  Files         338     324    -14     
  Lines       18334   18164   -170     
=======================================
- Hits        12586   12417   -169     
+ Misses       5748    5747     -1     

@Borda Borda added bug / fix Something isn't working enhancement New feature or request labels Oct 24, 2024
@Borda Borda changed the title Re-add numpy 2 support Re-add numpy 2+ support Oct 24, 2024
@Borda Borda changed the title Re-add numpy 2+ support Re-adding numpy 2+ support Oct 24, 2024
@Borda Borda merged commit 4c75369 into Lightning-AI:master Oct 24, 2024
61 of 64 checks passed
@adamjstewart adamjstewart deleted the deps/numpy branch October 24, 2024 10:34
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 4c75369)
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 4c75369)
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 4c75369)
Borda pushed a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit 4c75369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants