-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retain type of _modules
when renaming keys
#2793
Merged
Borda
merged 19 commits into
Lightning-AI:master
from
bfolie:bugfix/PT-2.5-module-collection
Oct 22, 2024
Merged
retain type of _modules
when renaming keys
#2793
Borda
merged 19 commits into
Lightning-AI:master
from
bfolie:bugfix/PT-2.5-module-collection
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfolie
requested review from
SkafteNicki,
justusschock and
Borda
as code owners
October 21, 2024 17:41
Borda
reviewed
Oct 21, 2024
Borda
reviewed
Oct 21, 2024
Borda
approved these changes
Oct 21, 2024
for more information, see https://pre-commit.ci
…bfolie/torchmetrics into bugfix/PT-2.5-module-collection
Borda
reviewed
Oct 21, 2024
Thanks @Borda, sorry for the confusion about the typing -- I haven't used flake8-comprehsions before |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2793 +/- ##
======================================
Coverage 68% 68%
======================================
Files 322 322
Lines 18046 18047 +1
======================================
+ Hits 12326 12327 +1
Misses 5720 5720 |
@SkafteNicki one issue remained:
|
…bfolie/torchmetrics into bugfix/PT-2.5-module-collection
for more information, see https://pre-commit.ci
Borda
changed the title
retain type of _modules when renaming keys
retain type of Oct 22, 2024
_modules
when renaming keys
SkafteNicki
approved these changes
Oct 22, 2024
Borda
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte <[email protected]> (cherry picked from commit be080dd)
Borda
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte <[email protected]> (cherry picked from commit be080dd)
Borda
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte <[email protected]> (cherry picked from commit be080dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2789
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2793.org.readthedocs.build/en/2793/