-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: merge_state
method
#2786
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2786 +/- ##
======================================
- Coverage 69% 69% -0%
======================================
Files 342 342
Lines 18699 18712 +13
======================================
+ Hits 12910 12912 +2
- Misses 5789 5800 +11 |
@Borda can you help me with the failing docs. It fails with error: |
still:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Might be worth creating an example on how to use TorchMetrics within a 2D or 3D parallel DTensor-based codebase in the future.
What does this PR do?
Fixes #2643
Seems most of the logic is already implemented in private methods so it is really just creating a public method + testing.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2786.org.readthedocs.build/en/2786/