-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to control the truncation in bert score #2776
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2776 +/- ##
========================================
- Coverage 69% 40% -30%
========================================
Files 334 334
Lines 18152 18153 +1
========================================
- Hits 12569 7180 -5389
- Misses 5583 10973 +5390 |
@SkafteNicki looks good, lets just check the typing :) |
for more information, see https://pre-commit.ci
@SkafteNicki, do you have any idea why it takes so long on PT 1.13? |
Not sure. If we just look at one of the new tests in this PR on 1.X it takes 75sec and in 2.X it takes 8sec. On my local laptop it takes around 4sec so it must be the 1.X build that something is wrong with. |
@Borda this time all of them took approximately the same amount of time so lets assume that it was a connection issue |
What does this PR do?
Fixes #2673
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2776.org.readthedocs.build/en/2776/