Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pearson changes inputs #2765

Merged
merged 8 commits into from
Oct 8, 2024
Merged

fix: pearson changes inputs #2765

merged 8 commits into from
Oct 8, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 1, 2024

What does this PR do?

reported by a user, thank you for also providing the fix

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2765.org.readthedocs.build/en/2765/

@SkafteNicki SkafteNicki self-assigned this Oct 8, 2024
@SkafteNicki SkafteNicki added this to the v1.4.x milestone Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41%. Comparing base (31ce89e) to head (f96cdef).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (31ce89e) and HEAD (f96cdef). Click for more details.

HEAD has 388 uploads less than BASE
Flag BASE (31ce89e) HEAD (f96cdef)
Windows 17 3
python3.8 18 3
cpu 117 20
torch1.13.1+cpu 18 3
torch2.4.0+cpu 6 1
python3.11 16 3
torch1.12.1+cpu 6 1
Linux 78 13
python3.9 54 9
torch1.11.0+cpu 6 1
torch1.10.2+cpu 6 1
macOS 22 4
python3.10 29 5
torch2.0.1 12 2
torch2.3.1+cpu 12 2
torch2.0.1+cpu 17 3
torch2.2.2+cpu 12 2
torch1.13.1 6 1
torch2.4.0+cu121 6 1
torch2.1.2+cpu 6 1
torch2.4.0 4 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2765     +/-   ##
========================================
- Coverage      69%     41%    -28%     
========================================
  Files         329     329             
  Lines       18077   18079      +2     
========================================
- Hits        12499    7466   -5033     
- Misses       5578   10613   +5035     

@SkafteNicki
Copy link
Member

The concordance metric depended on the in-place normalization of the variances so I just had to add that to the metric.

@mergify mergify bot added the ready label Oct 8, 2024
@Borda Borda merged commit f3b6278 into master Oct 8, 2024
61 of 62 checks passed
@Borda Borda deleted the fix/pearson branch October 8, 2024 17:21
Borda added a commit that referenced this pull request Oct 9, 2024
---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
(cherry picked from commit f3b6278)
Borda added a commit that referenced this pull request Oct 10, 2024
---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
(cherry picked from commit f3b6278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants