Fix corner case in MatthewsCorrcoef
#2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2743 +/- ##
========================================
- Coverage 69% 41% -28%
========================================
Files 329 329
Lines 18073 18077 +4
========================================
- Hits 12499 7479 -5020
- Misses 5574 10598 +5024 |
Borda
approved these changes
Sep 14, 2024
src/torchmetrics/functional/classification/matthews_corrcoef.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/matthews_corrcoef.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/matthews_corrcoef.py
Outdated
Show resolved
Hide resolved
Borda
force-pushed
the
master
branch
2 times, most recently
from
d0a5568 to
9fc79ae
Compare
github-actions
bot
added
the
documentation
Borda
force-pushed
the
bugfix/matthews_corrcoef
branch
2 times, most recently
from
d5daecb to
1156e69
Compare
Borda
force-pushed
the
bugfix/matthews_corrcoef
branch
from
1156e69 to
4dfa566
Compare
github-actions
bot
removed
the
documentation
Borda
pushed a commit
that referenced
this pull request
Oct 9, 2024
* fix + test * changelog * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 32290ca)
Borda
pushed a commit
that referenced
this pull request
Oct 10, 2024
* fix + test * changelog * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 32290ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2742
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2743.org.readthedocs.build/en/2743/