Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunLLM chat widget to TorchMetrics #2732

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

likawind
Copy link
Contributor

@likawind likawind commented Sep 10, 2024

What does this PR do?

Fixes Issue N/A

This PR adds RunLLM chat widget to torch metrics. The codespace has trouble building the sphnix so would appreciate if Lightning AI can provide guidance testing the change.

image

Before submitting
  • [ N/A ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • [ N/A ] Did you make sure to update the docs?
  • [ N/A ] Did you write any new necessary tests?
PR review

Lighting AI team are welcomed reviewing the PR as the goal is to enhance TorchMetric's documentation website :) .

Did you have fun?


📚 Documentation preview 📚: https://torchmetrics--2732.org.readthedocs.build/en/2732/

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 10, 2024
@mergify mergify bot added the ready label Sep 11, 2024
@likawind
Copy link
Contributor Author

Thanks for reviewing @Borda ! May I get your help having the 2nd person reviewing this PR? I'd also like to get some insight on this check failure as I don't think it's related to this change

@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Sep 14, 2024
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Borda Borda merged commit e107fd5 into Lightning-AI:master Sep 16, 2024
54 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants