-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle zero division error in binary IoU calculation #2726
Merged
Borda
merged 5 commits into
Lightning-AI:master
from
rittik9:fix/handle-zero-division-iou-calculation
Sep 10, 2024
Merged
Fix: handle zero division error in binary IoU calculation #2726
Borda
merged 5 commits into
Lightning-AI:master
from
rittik9:fix/handle-zero-division-iou-calculation
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rittik9
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
September 9, 2024 12:06
Borda
changed the title
Fix: Handle zero division error in binary IoU (Jaccard index) calcula…
Fix: handle zero division error in binary IoU calculation
Sep 9, 2024
Borda
approved these changes
Sep 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2726 +/- ##
========================================
- Coverage 69% 41% -28%
========================================
Files 329 316 -13
Lines 18065 17901 -164
========================================
- Hits 12491 7329 -5162
- Misses 5574 10572 +4998 |
justusschock
approved these changes
Sep 10, 2024
Borda
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Fix: Handle zero division error in binary IoU (Jaccard index) calculation * chlog --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 80929b5)
Borda
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Fix: Handle zero division error in binary IoU (Jaccard index) calculation * chlog --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 80929b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
What does this PR do?
Fixes #2658
Before submitting
Did you have fun?
Yes
Issue:
zero_division does not work for binary IoU (Jaccard index) calculation and returns NaN when
TP + FP + FN=0
.Reason:
The zero_division parameter in the BinaryJaccardIndex does not take effect during binary task calculations, as the IoU calculations for the binary task are returned early (Line 70) in
_jaccard_index_reduce
function.Fix:
The change replaces the direct division operation with a call to the
_safe_divide
function, which handles the case of division by zero based on the specifiedzero_division
parameter in_jaccard_index_reduce
function.📚 Documentation preview 📚: https://torchmetrics--2726.org.readthedocs.build/en/2726/