Skip to content

ci: prune testing matrix & set PT 2.4 as stable #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 2, 2024
Merged

ci: prune testing matrix & set PT 2.4 as stable #2670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c683d95
ci: prune testing matrix & set PT 2.4 as stable
Borda Aug 2, 2024
1a68b59
2.3.0 for mac
Borda Aug 2, 2024
ff96943
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 2, 2024
6098916
tests
Borda Aug 2, 2024
b0540cc
Merge branch 'ci/torch' of https://github.com/PyTorchLightning/metric…
Borda Aug 2, 2024
fd63e5b
versions
Borda Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure/gpu-integrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
torch-ver: "1.13"
requires: "oldest"
"torch | 2.x":
docker-image: "pytorch/pytorch:2.3.0-cuda12.1-cudnn8-runtime"
torch-ver: "2.3"
docker-image: "pytorch/pytorch:2.4.0-cuda12.1-cudnn9-runtime"
torch-ver: "2.4"
# how long to run the job before automatically cancelling
timeoutInMinutes: "40"
# how much time to give 'run always even if cancelled tasks' before stopping them
Expand Down
3 changes: 0 additions & 3 deletions .azure/gpu-unittests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ jobs:
docker-image: "ubuntu22.04-cuda11.8.0-py3.9-torch1.13"
torch-ver: "1.13"
"PyTorch | 2.X stable":
docker-image: "ubuntu22.04-cuda12.1.1-py3.11-torch2.3"
torch-ver: "2.3"
"PyTorch | 2.X future":
docker-image: "ubuntu22.04-cuda12.1.1-py3.11-torch2.4"
torch-ver: "2.4"
# how long to run the job before automatically cancelling
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/ci-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,28 +41,28 @@ jobs:
- "2.0.1"
- "2.1.2"
- "2.2.2"
- "2.3.0"
- "2.3.1"
- "2.4.0"
include:
# cover additional python nad PR combinations
# cover additional python and PT combinations
- { os: "ubuntu-22.04", python-version: "3.8", pytorch-version: "1.13.1" }
- { os: "ubuntu-22.04", python-version: "3.10", pytorch-version: "2.0.1" }
- { os: "ubuntu-22.04", python-version: "3.10", pytorch-version: "2.2.2" }
- { os: "ubuntu-22.04", python-version: "3.11", pytorch-version: "2.3.0" }
- { os: "ubuntu-22.04", python-version: "3.11", pytorch-version: "2.3.1" }
# standard mac machine, not the M1
- { os: "macOS-13", python-version: "3.8", pytorch-version: "1.13.1" }
- { os: "macOS-13", python-version: "3.10", pytorch-version: "2.0.1" }
- { os: "macOS-13", python-version: "3.11", pytorch-version: "2.2.2" }
# using the ARM based M1 machine
- { os: "macOS-14", python-version: "3.10", pytorch-version: "2.0.1" }
- { os: "macOS-14", python-version: "3.11", pytorch-version: "2.3.0" }
- { os: "macOS-14", python-version: "3.11", pytorch-version: "2.4.0" }
# some windows
- { os: "windows-2022", python-version: "3.8", pytorch-version: "1.13.1" }
- { os: "windows-2022", python-version: "3.10", pytorch-version: "2.0.1" }
- { os: "windows-2022", python-version: "3.11", pytorch-version: "2.3.0" }
# Future released version
- { os: "ubuntu-22.04", python-version: "3.11", pytorch-version: "2.4.0" }
- { os: "macOS-14", python-version: "3.11", pytorch-version: "2.4.0" }
- { os: "windows-2022", python-version: "3.11", pytorch-version: "2.4.0" }
# Future released version
#- { os: "ubuntu-22.04", python-version: "3.11", pytorch-version: "2.5.0" }
#- { os: "macOS-14", python-version: "3.11", pytorch-version: "2.5.0" }
#- { os: "windows-2022", python-version: "3.11", pytorch-version: "2.5.0" }
env:
FREEZE_REQUIREMENTS: ${{ ! (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release/')) }}
PYPI_CACHE_DIR: "_ci-cache_PyPI"
Expand Down Expand Up @@ -105,9 +105,9 @@ jobs:
pytorch-version: ${{ matrix.pytorch-version }}
pypi-dir: ${{ env.PYPI_CACHE_DIR }}

- name: Switch to PT test URL
if: ${{ matrix.pytorch-version == '2.4.0' }}
run: echo 'PIP_EXTRA_INDEX_URL=--extra-index-url https://download.pytorch.org/whl/test/cpu/' >> $GITHUB_ENV
#- name: Switch to PT test URL
# if: ${{ matrix.pytorch-version == '2.X.0' }}
# run: echo 'PIP_EXTRA_INDEX_URL=--extra-index-url https://download.pytorch.org/whl/test/cpu/' >> $GITHUB_ENV
- name: Install pkg
timeout-minutes: 25
run: |
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/docker-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ jobs:
- { python: "3.10", pytorch: "2.2", cuda: "12.1.1", ubuntu: "22.04" }
- { python: "3.11", pytorch: "2.2", cuda: "12.1.1", ubuntu: "22.04" }
- { python: "3.11", pytorch: "2.3", cuda: "12.1.1", ubuntu: "22.04" }
# the future version - test or RC version
- { python: "3.11", pytorch: "2.4", cuda: "12.1.1", ubuntu: "22.04" }
# the future version - test or RC version
#- { python: "3.11", pytorch: "2.5", cuda: "12.1.1", ubuntu: "22.04" }
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 1 addition & 1 deletion requirements/typing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
mypy ==1.11.0
torch ==2.3.1
torch ==2.4.0

types-PyYAML
types-emoji
Expand Down
Loading