-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakyness in tests related to torch.unique
with dim=None
#2650
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2650 +/- ##
========================================
- Coverage 69% 41% -27%
========================================
Files 316 316
Lines 17745 17745
========================================
- Hits 12185 7307 -4878
- Misses 5560 10438 +4878 |
seems like added retry helped but it would still be worse to know what is happening there... |
@Borda should be good now, found that the issue had to do with how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remane the PR to fit the fix...
torch.unique
with dim=None
* correct check * found the problem --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: jirka <[email protected]> (cherry picked from commit 0313c6b)
* correct check * found the problem --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: jirka <[email protected]> (cherry picked from commit 0313c6b)
What does this PR do?
One of test seems to be flaky. See for example this CI run:
https://github.com/Lightning-AI/torchmetrics/actions/runs/10037067157/job/27736179139?pr=2636#step:16:839
Trying to debug why this is happening
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2650.org.readthedocs.build/en/2650/