Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight BERTScore gallery modifications for accuracy and styling #2642

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

baskrahmer
Copy link
Collaborator

@baskrahmer baskrahmer commented Jul 22, 2024

What does this PR do?

The example was a bit inconsistent (introduction mentions summarization, but actual code not). I made some changes to clarify this.
In addition I removed the temperature kwarg (not needed when do_sample=False) and changes the styling a bit.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2642.org.readthedocs.build/en/2642/

@baskrahmer baskrahmer changed the title Slight modifications for accuracy and styling Slight BERTScore gallery modifications for accuracy and styling Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (d8235b2) to head (5e6616d).
Report is 105 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2642   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         316     316           
  Lines       17881   17881           
======================================
  Hits        12331   12331           
  Misses       5550    5550           

@mergify mergify bot added the ready label Jul 23, 2024
@mergify mergify bot added ready and removed ready labels Jul 23, 2024
@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Jul 25, 2024
@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Jul 25, 2024
@SkafteNicki SkafteNicki merged commit eaa85e0 into Lightning-AI:master Jul 25, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants